Skip to content

chore: add debian packaging #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

NeroReflex
Copy link
Contributor

This PR add support for building .deb packages on both debian 12 and ubuntu 24.04 LTS

I also added the authors field otherwise cargo deb will fail since .deb packages requires a maintainer field.

I tested the CI on my fork coping both blocks into the "build" hook.

@pastaq
Copy link
Contributor

pastaq commented Mar 9, 2025

Can you link the successful CI from your branch?

Copy link
Contributor

@ShadowApex ShadowApex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but thank you for these changes!

run: |
export DEBIAN_FRONTEND=noninteractive
apt-get update
apt-get install -y wget git lsb-release wget software-properties-common gnupg curl build-essential devscripts debhelper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we put these steps inside a Dockerfile and adding a new target in our Makefile to build the debian package so it's easy for us to build the deb package without the GitHub action.

This also makes it easier for us to switch to a different CI solution other than GitHub Actions if we ever need to do so.

Copy link
Contributor Author

@NeroReflex NeroReflex Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a dist-deb very similar to the dist-rpm.
I was unable to make use of an in-repo Dockerfile without giving direct docker commands. I personally find that a bit ugly and unnecessary given dependencies are listed there, but if you want that I can put those command in the github CI, just be aware the file won't look particularly nice afterward.

P.S. https://github.com/NeroReflex/InputPlumber/actions/runs/13750997327/job/38451946023 is the most recent build with make-deb

@NeroReflex
Copy link
Contributor Author

Can you link the successful CI from your branch?

https://github.com/NeroReflex/InputPlumber/actions/runs/13750158722/job/38450112628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants